Attention is currently required from: pespin.

View Change

1 comment:

• File library/Osmocom_CTRL_Functions.ttcn:

  • Patch Set #2, Line 47: log2str

    What's the reason there? Because it gets in the way of searching for setverdict() in the code?

    I am fine with using `f_shutdown()` instead of `mtc.stop`, because this way we [hopefully] stop all PTCs and logs a very useful message with the file and line number from where the shutdown was called. But I don't see if win anything by [ab]using `f_shutdown()` for setting the verdict: you have to use `log2str()` and the message ends up further away towards the line length limit. It looks ugly and cumbersome to me that way.

    I generally don't like that `f_shutdown()` is even usable to set a verdict by design. Ideally it should only do what its name suggests (following the UNIX philosophy): shutdown all the parallel components. There exists built-in API for setting a verdict - `setverdict()`, which does concatenate all arguments following after the `verdictop` into a single string automatically and does not require to use TITAN specific extensions like `log2str()`.

    This is my take on it. Looks like nobody else does share this view.

To view, visit change 38882. To unsubscribe, or for help writing mail filters, visit settings.