Attention is currently required from: pespin. lynxis has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email ) Change subject: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN ...................................................................... Patch Set 3: (5 comments) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/5d4e2b51_a90401... : PS2, Line 985: goto out;
What do you mean? why not sending it here? that we need to fix it for all branches which uses `goto out`.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/1237faa9_dc2c8a... : PS2, Line 990: asp->tcap.enabled = true;
I'd leave it as before and simply add a new message which can be sent before enabling it, this follo […] Done
File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/0e01f5ab_1faaea... : PS3, Line 264: assoc->asp->tcap.enabled && assoc->asp->tcap.accept_new_trans)
Please put the added condition into a new line. Done
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/4b663ca4_5e81f4... : PS3, Line 264: assoc->asp->tcap.enabled && assoc->asp->tcap.accept_new_trans)
Please put the added condition into a new line. Done
File src/tcap_as_loadshare_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/99fdbaf6_d4a957... : PS3, Line 161: if (!assoc->asp->tcap.enabled || !osmo_ss7_asp_active(assoc->asp))
it probably makes sense to also print the inactive ones and add a column which prints "ACTIVE" | "IN […] The other I found, was using Yes and No. But there can't be any inactive ASP in this table, because tcap.enabled can't be true for any inactive one
-- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id4e7bb022a0c8b52369f6ded2729cf6cf8679556 Gerrit-Change-Number: 43999 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 13 Nov 2026 19:37:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: lynxis <lynxis@fe80.eu>