Attention is currently required from: pespin.
5 comments:
File src/tcap_as_loadshare.c:
Patch Set #2, Line 985: goto out;
What do you mean? why not sending it here?
that we need to fix it for all branches which uses `goto out`.
Patch Set #2, Line 990: asp->tcap.enabled = true;
I'd leave it as before and simply add a new message which can be sent before enabling it, this follo […]
Done
File src/tcap_as_loadshare.c:
Patch Set #3, Line 264: assoc->asp->tcap.enabled && assoc->asp->tcap.accept_new_trans)
Please put the added condition into a new line.
Done
Patch Set #3, Line 264: assoc->asp->tcap.enabled && assoc->asp->tcap.accept_new_trans)
Please put the added condition into a new line.
Done
File src/tcap_as_loadshare_vty.c:
Patch Set #3, Line 161: if (!assoc->asp->tcap.enabled || !osmo_ss7_asp_active(assoc->asp))
it probably makes sense to also print the inactive ones and add a column which prints "ACTIVE" | "IN […]
The other I found, was using Yes and No.
But there can't be any inactive ASP in this table, because tcap.enabled can't be true for any inactive one
To view, visit change 43999. To unsubscribe, or for help writing mail filters, visit settings.