Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/32985 )
Change subject: rlcmac: Submit GMMRR-PAGE.ind upon rx of Paging Request Type 1/2 ......................................................................
Patch Set 3: Code-Review+1
(4 comments)
File include/osmocom/gprs/rlcmac/rlcmac_private.h:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32985/comment/83721c8a_3e912253 PS2, Line 94: gprs_rlcmac_handle_ccch_pag_req_1
cosmetic: maybe `..._pag_req1` or `... […]
Done
File src/rlcmac/rlcmac.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32985/comment/f3574901_7ee3c364 PS2, Line 352: if (GSM_MACBLOCK_LEN < sizeof(*pag))
that's from previous code where GSM_MACBLOCK_LEN used to be msgb_l3len(msg), I'll drop it.
Done
https://gerrit.osmocom.org/c/libosmo-gprs/+/32985/comment/da8a60be_e030a86b PS2, Line 363: if (GSM_MACBLOCK_LEN < sizeof(*pag) + 1)
same.
Done
File tests/rlcmac/rlcmac_prim_test.err:
https://gerrit.osmocom.org/c/libosmo-gprs/+/32985/comment/800b4630_38b61e60 PS3, Line 804: 74 remaining bits unhandled by decoder Is this expected? Looks like the CSN.1 definition does not account for padding.