Attention is currently required from: pespin.

Patch set 3:Code-Review +1

View Change

4 comments:

• File include/osmocom/gprs/rlcmac/rlcmac_private.h:

  • Patch Set #2, Line 94: gprs_rlcmac_handle_ccch_pag_req_1

    cosmetic: maybe `..._pag_req1` or `... […]

    Done

• File src/rlcmac/rlcmac.c:

  • Patch Set #2, Line 352: if (GSM_MACBLOCK_LEN < sizeof(*pag))

    that's from previous code where GSM_MACBLOCK_LEN used to be msgb_l3len(msg), I'll drop it.

    Done

  • Patch Set #2, Line 363: if (GSM_MACBLOCK_LEN < sizeof(*pag) + 1)

    same.

    Done

• File tests/rlcmac/rlcmac_prim_test.err:

  • Patch Set #3, Line 804: 74 remaining bits unhandled by decoder

    Is this expected? Looks like the CSN.1 definition does not account for padding.

To view, visit change 32985. To unsubscribe, or for help writing mail filters, visit settings.