Attention is currently required from: jolly, fixeria, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32694 )
Change subject: gprs_rlcmac: also use PCU_IF_SAPI_PCH_DT for paging MAC blocks ......................................................................
Patch Set 3:
(2 comments)
File src/gprs_rlcmac.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/e87f1a09_fc3b2929 PS1, Line 49: mi->tmsi
gprs_rlcmac_paging_request() is called from gprs_bssgp_pcu. […]
I have now analyzed this further. The PCUIF really behaves a bit confusing here. It is true that osmo-bts confirms IMMEDIATE ASSIGNMENT and PAGING COMMANDs but osmo-pcu will silently drop the confirmations for PAGING COMMAND messages. I have already fixed this in osmo-bts and we also do not have to worry about the TMSI, we can just pass GSM_RESERVED_TMSI and everything will be fine.
File src/gprs_rlcmac.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/32694/comment/f05f4833_6b7d80d3 PS2, Line 33: The caller must use a TMSI/TLLI
Is there anything in the specs. […]
I just deducted that from the code, we always set mi.type to GSM_MT_TYPE_TMSI. I just wanted to make sure that we won't overlook anything if we should change this. But since we do not need the TMSI/TLLI for the confirmation anymore (see below) this line is no longer needed.