Attention is currently required from: jolly, fixeria, pespin.

View Change

2 comments:

• File src/gprs_rlcmac.c:

  • Patch Set #1, Line 49: mi->tmsi

    gprs_rlcmac_paging_request() is called from gprs_bssgp_pcu. […]

    I have now analyzed this further. The PCUIF really behaves a bit confusing here. It is true that osmo-bts confirms IMMEDIATE ASSIGNMENT and PAGING COMMANDs but osmo-pcu will silently drop the confirmations for PAGING COMMAND messages. I have already fixed this in osmo-bts and we also do not have to worry about the TMSI, we can just pass GSM_RESERVED_TMSI and everything will be fine.

• File src/gprs_rlcmac.c:

  • Patch Set #2, Line 33: The caller must use a TMSI/TLLI

    Is there anything in the specs. […]

    I just deducted that from the code, we always set mi.type to GSM_MT_TYPE_TMSI. I just wanted to make sure that we won't overlook anything if we should change this. But since we do not need the TMSI/TLLI for the confirmation anymore (see below) this line is no longer needed.

To view, visit change 32694. To unsubscribe, or for help writing mail filters, visit settings.