Attention is currently required from: pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40493?usp=email ) Change subject: Add multiple messages buffers to io_uring write operations ...................................................................... Patch Set 7: (5 comments) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/38629ece_28e3e269?u... : PS4, Line 248: lh = iofd->tx_queue.msg_queue.prev;
You added it to libosmocore but apparently not using it here? I fogot to remove this function. I was already using llist_last_entry_or_null().
https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/1d4d96d5_8c0d3497?u... : PS4, Line 444: /* Re-enqueue remaining buffers. */
Here we should improve it by adding new msg from the tx_queue into the iov if we aren't yet doing it […] Then we must change the way the tx_queue stores. Currently it stores msghdrs, but we would need to store msgbs. It makes this much more complex.
https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/bfff97ec_18737813?u... : PS4, Line 465: iofd->io_ops.write_cb(iofd, (rc < 0) ? rc : chunk, msg);
Again, by incorporation the negative value case into chunk variable, we can simplify all these lines […] Done
https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/d0e4fd57_ed6a5e70?u... : PS4, Line 479: msgb_free(msghdr->msg[idx]);
msghdr->msg[idx] = NULL; Done
https://gerrit.osmocom.org/c/libosmocore/+/40493/comment/6e737520_f1bf4096?u... : PS4, Line 517: msghdr = iofd_txqueue_tail(iofd);
Not done, not answered, no comment explaining in code. I wrote it abovethe function call llist_last_entry_or_null().
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8c4e0a785cf66becd7fb5b2caf718c9724b56686 Gerrit-Change-Number: 40493 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 23 Jul 2025 10:46:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas@eversberg.eu> Comment-In-Reply-To: pespin <pespin@sysmocom.de>