Attention is currently required from: pespin.

View Change

5 comments:

• File src/core/osmo_io.c:

  • Patch Set #4, Line 248: lh = iofd->tx_queue.msg_queue.prev;

    You added it to libosmocore but apparently not using it here?

    I fogot to remove this function. I was already using llist_last_entry_or_null().

  • Patch Set #4, Line 444: /* Re-enqueue remaining buffers. */

    Here we should improve it by adding new msg from the tx_queue into the iov if we aren't yet doing it […]

    Then we must change the way the tx_queue stores. Currently it stores msghdrs, but we would need to store msgbs. It makes this much more complex.

  • Patch Set #4, Line 465: iofd->io_ops.write_cb(iofd, (rc < 0) ? rc : chunk, msg);

    Again, by incorporation the negative value case into chunk variable, we can simplify all these lines […]

    Done

  • Patch Set #4, Line 479: msgb_free(msghdr->msg[idx]);

    msghdr->msg[idx] = NULL;

    Done

  • Patch Set #4, Line 517: msghdr = iofd_txqueue_tail(iofd);

    Not done, not answered, no comment explaining in code.

    I wrote it abovethe function call llist_last_entry_or_null().

To view, visit change 40493. To unsubscribe, or for help writing mail filters, visit settings.