Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144 ) Change subject: BSSMAP_Templates: Add templates to receive CellID IE ...................................................................... Patch Set 3: Code-Review-1 (2 comments) File library/BSSMAP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144/comment/d1d59a71_dac29... PS3, Line 371: present There's still something wrong with this template. The `present` means that either a value or a template `?` can be passed. Passing a `?` would result in a DTE, because `valueof(?)` cannot be evaluated. Given the limitations of `t[rs]_BSSMAP_CI_CGI`, in particular having to call `f_enc_mcc_mnc()`, both parameters `mcc` and `mnc` should be defined as regular values, not templates. Other params *can* be templates because functions `f_tr_LAC` and `f_tr_CI` should be capable of handling them. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144/comment/bc987b3b_7abdf... PS3, Line 1467: GsmMcc mcc, GsmMnc mnc Here I suggest keeping both `mcc` and `mnc` as they are, i.e. value parameters. The remaining `lac` and `ci` should be `template (present)`. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I42d52d871c8011db7e0897dfe752afeefa6d9662 Gerrit-Change-Number: 33144 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Comment-Date: Tue, 06 Jun 2023 14:09:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment