Attention is currently required from: jolly.

Patch set 3:Code-Review -1

View Change

2 comments:

• File library/BSSMAP_Templates.ttcn:

  • Patch Set #3, Line 371: present

    There's still something wrong with this template. The `present` means that either a value or a template `?` can be passed. Passing a `?` would result in a DTE, because `valueof(?)` cannot be evaluated.

    Given the limitations of `t[rs]_BSSMAP_CI_CGI`, in particular having to call `f_enc_mcc_mnc()`, both parameters `mcc` and `mnc` should be defined as regular values, not templates. Other params *can* be templates because functions `f_tr_LAC` and `f_tr_CI` should be capable of handling them.

  • Patch Set #3, Line 1467: GsmMcc mcc, GsmMnc mnc

    Here I suggest keeping both `mcc` and `mnc` as they are, i.e. value parameters.
    The remaining `lac` and `ci` should be `template (present)`.

To view, visit change 33144. To unsubscribe, or for help writing mail filters, visit settings.