Attention is currently required from: laforge, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28809 ) Change subject: trxcon: rework trxcon_fsm, move into a separate file ...................................................................... Patch Set 3: Code-Review+1 (5 comments) File src/host/trxcon/src/l1ctl.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/d9ef0347_805e253e PS3, Line 467: /* FIXME: we cannot know for sure if the given mode was actually applied. can this be fixed? the comment sounds like it can't but there's a FIXME infront File src/host/trxcon/src/trxcon_fsm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/3a57afc8_4c83ec71 PS3, Line 52: /* TODO: osmo_fsm_inst_term(fi, OSMO_FSM_TERM_ERROR, NULL); */ kept on purpose? https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/e29a713a_dc6b26ba PS3, Line 127: /* TODO: timeout */ kept on purpose? https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/77cbe446_8d40f950 PS3, Line 210: "); missing \n https://gerrit.osmocom.org/c/osmocom-bb/+/28809/comment/bcb7166b_09fd7094 PS3, Line 280: /* TODO: set proper .snr */ kept on purpose? same below -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28809 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifaf63ead9dd180181358e771367b2a686ba159ca Gerrit-Change-Number: 28809 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Fri, 29 Jul 2022 11:12:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment