Attention is currently required from: laforge, fixeria.

Patch set 3:Code-Review +1

View Change

5 comments:

• File src/host/trxcon/src/l1ctl.c:

  • Patch Set #3, Line 467: /* FIXME: we cannot know for sure if the given mode was actually applied.

    can this be fixed? the comment sounds like it can't but there's a FIXME infront

• File src/host/trxcon/src/trxcon_fsm.c:

  • Patch Set #3, Line 52: /* TODO: osmo_fsm_inst_term(fi, OSMO_FSM_TERM_ERROR, NULL); */

    kept on purpose?

  • Patch Set #3, Line 127: /* TODO: timeout */

    kept on purpose?

  • Patch Set #3, Line 210: ");

    missing \n

  • Patch Set #3, Line 280: /* TODO: set proper .snr */

    kept on purpose? same below

To view, visit change 28809. To unsubscribe, or for help writing mail filters, visit settings.