Attention is currently required from: falconia, osmith.
fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email )
Change subject: nokia: add support for Flexi Multiradio ......................................................................
Patch Set 1: Code-Review+1 Verified+1
(2 comments)
File include/osmocom/bsc/bts.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/cbe3cb95_d351790f?usp=... : PS1, Line 512: 256 cosmetic: add define for `256` too, e.g. `NOKIA_OML_MAX_SEGMENT_LEN`?
File src/osmo-bsc/bts_nokia_site.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/7dd039e3_cdca7d30?usp=... : PS1, Line 1785: static int abis_nm_rcvmsg_fom(struct e1inp_sign_link *sign_link,
Avoid multiple line dereference - prefer 'run.static' […]
The liner is indeed hallucinating here. Might be something for @osmith@sysmocom.de to check. For now, I am simply removing Jenkins' V-1 vote and adding my V+1.