Attention is currently required from: falconia, osmith.

Patch set 1:Verified +1Code-Review +1

View Change

2 comments:

• File include/osmocom/bsc/bts.h:

  • Patch Set #1, Line 512: 256

    cosmetic: add define for `256` too, e.g. `NOKIA_OML_MAX_SEGMENT_LEN`?

• File src/osmo-bsc/bts_nokia_site.c:

  • Patch Set #1, Line 1785: static int abis_nm_rcvmsg_fom(struct e1inp_sign_link *sign_link,

    > Avoid multiple line dereference - prefer 'run.static' […]

    The liner is indeed hallucinating here. Might be something for @osmith@sysmocom.de to check.
    For now, I am simply removing Jenkins' V-1 vote and adding my V+1.

To view, visit change 42712. To unsubscribe, or for help writing mail filters, visit settings.