Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34467?usp=email ) Change subject: sccp: Introduce initial support for SCCP LUDT + LUDTS messages ...................................................................... Patch Set 5: Code-Review+1 (6 comments) File include/osmocom/sccp/sccp_types.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/11fea04a_589fb659 PS2, Line 505: #if VARIABLE
Yeah I think so, I also was a bit confused. I simply followed the existing code here... Ack
https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/7fc5b164_b25fe905 PS2, Line 529:
indent with one less tab here for consistency with the rest of the file? Done
https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/96486ab2_786688d3 PS2, Line 543: importancd
importance (same typo is elsewhere in the file too) Done
File src/sccp2sua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/d8f6e364_35597024 PS2, Line 1449: sccp_longdata_to_sua_ptr(xua, SUA_IEI_DATA, (uint8_t *)&ludt->variable_data);
You mean for the optional? part? because the DATA part is being checked above it. […] Ack
File tests/xua/sccp_test_data.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/074d004c_82f1ff2b PS5, Line 154: 0xab, 0xab, 0xab, missing indetation File tests/xua/xua_test.ok: https://gerrit.osmocom.org/c/libosmo-sccp/+/34467/comment/eb727241_8bc4bc58 PS2, Line 102: Input != re-encoded output!
I need to check, I think it's because the params I'm passing to re-encode it are wrong (not matching […] Done
-- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34467?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ic91abfc921f5e4f36045bfa325333112cddd9fa6 Gerrit-Change-Number: 34467 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 21 Sep 2023 14:32:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment