Attention is currently required from: fixeria, pespin.

Patch set 5:Code-Review +1

View Change

6 comments:

• File include/osmocom/sccp/sccp_types.h:

  • Patch Set #2, Line 505: #if VARIABLE

    Yeah I think so, I also was a bit confused. I simply followed the existing code here...

    Ack

  • Patch Set #2, Line 529:

    indent with one less tab here for consistency with the rest of the file?

    Done

  • Patch Set #2, Line 543: importancd

    importance (same typo is elsewhere in the file too)

    Done

• File src/sccp2sua.c:

  • Patch Set #2, Line 1449: sccp_longdata_to_sua_ptr(xua, SUA_IEI_DATA, (uint8_t *)&ludt->variable_data);

    You mean for the optional? part? because the DATA part is being checked above it. […]

    Ack

• File tests/xua/sccp_test_data.c:

  • Patch Set #5, Line 154: 0xab, 0xab, 0xab,

    missing indetation

• File tests/xua/xua_test.ok:

  • Patch Set #2, Line 102: Input != re-encoded output!

    I need to check, I think it's because the params I'm passing to re-encode it are wrong (not matching […]

    Done

To view, visit change 34467. To unsubscribe, or for help writing mail filters, visit settings.