Attention is currently required from: Hoernchen.
dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43540?usp=email )
Change subject: bip: move the BIP relay into pySim.bip ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Patchset:
PS2: Ths patch had no "Verifed" result, I have re-triggered the Jenkins build, but the build seems to take very long. I hope it will finish overnight...
File tests/unittests/test_bip_relay.py:
https://gerrit.osmocom.org/c/pysim/+/43540/comment/923712bf_c3f471e4?usp=ema... : PS1, Line 28: with a card that sends one, and one that has one must get the PDU.""" I only see sms_sink? Were there crashes before, did you change the code when moving it to the bip module?
https://gerrit.osmocom.org/c/pysim/+/43540/comment/f203b9f7_0ac00edf?usp=ema... : PS1, Line 40: Proact(sms_sink=seen.append).send_sms_via_smpp(self._submit()) maybe create the Proact object first and use it then. Maybe also assert on it to make sure the constructor has stored the sms_sink callback as class property?