Attention is currently required from: Hoernchen.
Patch set 2:Code-Review +1
3 comments:
Patchset:
Ths patch had no "Verifed" result, I have re-triggered the Jenkins build, but the build seems to take very long. I hope it will finish overnight...
File tests/unittests/test_bip_relay.py:
Patch Set #1, Line 28: with a card that sends one, and one that has one must get the PDU."""
I only see sms_sink? Were there crashes before, did you change the code when moving it to the bip module?
Patch Set #1, Line 40: Proact(sms_sink=seen.append).send_sms_via_smpp(self._submit())
maybe create the Proact object first and use it then. Maybe also assert on it to make sure the constructor has stored the sms_sink callback as class property?
To view, visit change 43540. To unsubscribe, or for help writing mail filters, visit settings.