Attention is currently required from: Jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30446 ) Change subject: Fix support for HDLC/RAW type channels at mISDN.c ...................................................................... Patch Set 1: (2 comments) File src/input/misdn.c: https://gerrit.osmocom.org/c/libosmo-abis/+/30446/comment/f62af4b8_cfd759b2 PS1, Line 502: LOGL_DEBUG Not critical, but given this is quite unexpected, I would guess this migth be worth a higher level than debug? notice? https://gerrit.osmocom.org/c/libosmo-abis/+/30446/comment/1dd3d75a_06b1f828 PS1, Line 690: /* TS 16 is the D-channel, so we use D-channel proto */ : bfd->fd = socket(PF_ISDN, SOCK_DGRAM, : (ts == 16) ? ISDN_P_NT_E1 : ISDN_P_B_HDLC); the problem here is that it makes assumptions. For [public] ISDN it is defined trhat signaling is (only) on TS16. But that's not always the caase - nor is TS16 always the only channel used for signaling. Futhermore, who says that all libosmo-abis users will always want to run in NT mode? Also: I'm wondering why we didn't need this so far? Even for actual Abis, we have simply used E1INP_TS_TYPE_SIGN with ISDN_P_B_HDLC (as seen below) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30446 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie9a2a3f6ae1ad7da1711b6ff2f0aeda39839a427 Gerrit-Change-Number: 30446 Gerrit-PatchSet: 1 Gerrit-Owner: Jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: Jolly <andreas@eversberg.eu> Gerrit-Comment-Date: Mon, 05 Dec 2022 08:35:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment