Attention is currently required from: Jolly.

View Change

2 comments:

• File src/input/misdn.c:

  • Patch Set #1, Line 502: LOGL_DEBUG

    Not critical, but given this is quite unexpected, I would guess this migth be worth a higher level than debug? notice?

  • Patch Set #1, Line 690:

    		/* TS 16 is the D-channel, so we use D-channel proto */
    			bfd->fd = socket(PF_ISDN, SOCK_DGRAM,
    				(ts == 16) ? ISDN_P_NT_E1 : ISDN_P_B_HDLC);
    

    the problem here is that it makes assumptions. For [public] ISDN it is defined trhat signaling is (only) on TS16. But that's not always the caase - nor is TS16 always the only channel used for signaling.

    Futhermore, who says that all libosmo-abis users will always want to run in NT mode?

    Also: I'm wondering why we didn't need this so far? Even for actual Abis, we have simply used E1INP_TS_TYPE_SIGN with ISDN_P_B_HDLC (as seen below)

To view, visit change 30446. To unsubscribe, or for help writing mail filters, visit settings.