Attention is currently required from: laforge, osmith, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email )
Change subject: SIP_Emulation: Rename component id
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641/comment/c8430c6d_29a7…
PS1, Line 9: it makes it impossible to reference the
: component name under TESTPORT_PARAMETERS
This scaping of dashes through quotes looks more like
a workaround placed after the name was place, and imo makes everything more difficult for
no good reason.
So you're saying using quotes makes everything more difficult for no good reason? To
me this patch looks like a workaround for a problem, which is not really a problem,
because TITAN provides means to reference components with dashes in the names out of the
box. If renaming stuff & refactoring code is easier for you, then I have nothing to
say :D
It's like putting spaces in files. Can be done?
yes? Should we? No.
I don't see a connection with the component name escaping.
I'm not aware we have a comprehensive guide on how
to name components that we have to follow :)
Just like with many other things we tend to follow in the code base.
One can always use this as an excuse to avoid addressing code review.
The problem, though, is that this patch brings inconsistency to the code.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iecefe7d98a5842872f1efc55e013f672186ef1a8
Gerrit-Change-Number: 36641
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 26 Apr 2024 13:46:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment