Attention is currently required from: laforge, osmith, pespin.
1 comment:
Commit Message:
it makes it impossible to reference the
component name under TESTPORT_PARAMETERS
This scaping of dashes through quotes looks more like a workaround placed after the name was place, and imo makes everything more difficult for no good reason.
So you're saying using quotes makes everything more difficult for no good reason? To me this patch looks like a workaround for a problem, which is not really a problem, because TITAN provides means to reference components with dashes in the names out of the box. If renaming stuff & refactoring code is easier for you, then I have nothing to say :D
It's like putting spaces in files. Can be done? yes? Should we? No.
I don't see a connection with the component name escaping.
I'm not aware we have a comprehensive guide on how to name components that we have to follow :)
Just like with many other things we tend to follow in the code base.
One can always use this as an excuse to avoid addressing code review.
The problem, though, is that this patch brings inconsistency to the code.
To view, visit change 36641. To unsubscribe, or for help writing mail filters, visit settings.