Attention is currently required from: fixeria, laforge, neels, osmith, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 25: (11 comments) Patchset: PS5:
Thanks a lot for the thorough review and for the positive assessment of the patch cleanliness — real […] Done
Patchset: PS21:
^ still a lot of unresolved threads, please follow what was requested here, thanks! Done — all addressed threads have been resolved. Thanks!
Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/46209c92_fcec0507?u... : PS5, Line 7: Add Emscripten build support and JS callback logging backend
Thank you for asking for additional context. […] Done
File src/core/netdev.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/ff6e8e95_1fc3fb87?u... : PS5, Line 67: #if (!EMBEDDED) && !defined(__EMSCRIPTEN__)
I've moved the netdev changes into a separate patch and will address that first. […] Done
File src/core/osmo_io_internal.h: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/cd4536aa_67a4e8c8?u... : PS16, Line 5: #include "../config.h"
Done, split out and submitted as a separate patch. Done
File src/core/serial.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/084e8e7e_15e34d62?u... : PS5, Line 27: #if !defined(__EMSCRIPTEN__)
Thanks for the note! […] Done
File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/0529e3b3_50bf8187?u... : PS5, Line 2050: #ifdef HAVE_LIBSCTP
Thanks for pointing this out. […] Done
https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/6f6b8e0f_55be83d3?u... : PS5, Line 1928: #ifdef HAVE_LIBSCTP
Thanks for pointing this out. […] Done
File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/9b2d4fb5_6c0c3557?u... : PS7, Line 1698: #if defined(__linux__) || defined(__EMSCRIPTEN__)
Agreed. I’ve added a configure-time compile test in configure. […] Done
File src/core/stats_tcp.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/ad67bc08_b7d9fab3?u... : PS16, Line 198: #if !defined(__EMSCRIPTEN__)
The build fails due to missing Linux-specific headers/types. […] Done
File src/vty/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/433bf685_dbd62dcb?u... : PS5, Line 36: libosmovty_la_SOURCES += telnet_interface_dummy.c
You are right, the issue turned out to be more specific than initially assumed. […] Done
-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 25 Gerrit-Owner: Timur Davydov <dtv.comp@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 03 Feb 2026 16:56:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de> Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp@gmail.com>