Attention is currently required from: fixeria, laforge, neels, osmith, pespin.

View Change

11 comments:

• Patchset:

  • Patch Set #5:

    Thanks a lot for the thorough review and for the positive assessment of the patch cleanliness — real […]

    Done

• Patchset:

  • Patch Set #21:

    ^ still a lot of unresolved threads, please follow what was requested here, thanks!

    Done — all addressed threads have been resolved. Thanks!

• Commit Message:

  • Patch Set #5, Line 7: Add Emscripten build support and JS callback logging backend

    Thank you for asking for additional context. […]

    Done

• File src/core/netdev.c:

  • Patch Set #5, Line 67: #if (!EMBEDDED) && !defined(__EMSCRIPTEN__)

    I've moved the netdev changes into a separate patch and will address that first. […]

    Done

• File src/core/osmo_io_internal.h:

  • Patch Set #16, Line 5: #include "../config.h"

    Done, split out and submitted as a separate patch.

    Done

• File src/core/serial.c:

  • Patch Set #5, Line 27: #if !defined(__EMSCRIPTEN__)

    Thanks for the note! […]

    Done

• File src/core/socket.c:

  • Patch Set #5, Line 2050: #ifdef HAVE_LIBSCTP

    Thanks for pointing this out. […]

    Done

  • Patch Set #5, Line 1928: #ifdef HAVE_LIBSCTP

    Thanks for pointing this out. […]

    Done

• File src/core/socket.c:

  • Patch Set #7, Line 1698: #if defined(__linux__) || defined(__EMSCRIPTEN__)

    Agreed. I’ve added a configure-time compile test in configure. […]

    Done

• File src/core/stats_tcp.c:

  • Patch Set #16, Line 198: #if !defined(__EMSCRIPTEN__)

    The build fails due to missing Linux-specific headers/types. […]

    Done

• File src/vty/Makefile.am:

  • Patch Set #5, Line 36: libosmovty_la_SOURCES += telnet_interface_dummy.c

    You are right, the issue turned out to be more specific than initially assumed. […]

    Done

To view, visit change 41813. To unsubscribe, or for help writing mail filters, visit settings.