Attention is currently required from: Hoernchen, laforge, lynxis lazus. Hello Jenkins Builder, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by lynxis lazus, Verified+1 by Jenkins Builder Change subject: firmware: use the full 11 bit US_FIDI.FI_DI_RATIO ...................................................................... firmware: use the full 11 bit US_FIDI.FI_DI_RATIO US_FIDI_FI_DI_RATIO_Msk is 0x7ff, cemu rejected >= 0x400 in emu_update_fidi() and masked with 0x3ff in card_emu_uart_update_fidi(), but update_fidi() used by the sniffer already used 0x7ff. -> ratios 1024..2047 are unusable in cemu, which is the entire upper half of ISO 7816-3 Table 7 at Di=1. A reader trying one of those in a PPS gets the proposal echoed and accepted, after which the card keeps transmitting at the old rate. FI_DI_RATIO is clock periods per bit -> larger ratio is a SLOWER link. The old check rejected slow values but accepted Fi=372/Di=64, ratio 5 !? Unify and use the register mask (= shifed by 0 so usable as value) and reject ratios that do not fit rather than truncating to garbage dividers. Change-Id: I6211dd5be7c5c5d2150af2aa37a403b33e6d340d --- M firmware/libcommon/source/card_emu.c M firmware/libcommon/source/mode_cardemu.c M firmware/libcommon/source/simtrace_iso7816.c 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/25/43125/2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I6211dd5be7c5c5d2150af2aa37a403b33e6d340d Gerrit-Change-Number: 43125 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu>