Attention is currently required from: daniel, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37866?usp=email )
Change subject: Implement correct Routing Area based paging ......................................................................
Patch Set 5: Code-Review-1
(3 comments)
File src/sgsn/gprs_routing_area.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37866/comment/24c9af63_321001ef?usp... : PS5, Line 315: llist_for_each_entry(cell, &ra->cells, list) {
space required before the open parenthesis '('
Please fix.
https://gerrit.osmocom.org/c/osmo-sgsn/+/37866/comment/5fcae8c4_80640db3?usp... : PS5, Line 319: } /* TODO for UTRAN */ here I guess?
File src/sgsn/sgsn_vty.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37866/comment/d4e0b7af_f8b59673?usp... : PS5, Line 1338: rate_ctr_inc(rate_ctr_group_get_ctr(mm->ctrg, GMM_CTR_PAGING_PS)); I don't really like the fact that now we have this counter incremented in several places. I'd put this into the function doing the paging.