Attention is currently required from: daniel, lynxis lazus.

Patch set 5:Code-Review -1

View Change

3 comments:

• File src/sgsn/gprs_routing_area.c:

  • Patch Set #5, Line 315: llist_for_each_entry(cell, &ra->cells, list) {

    space required before the open parenthesis '('

    Please fix.

  • Patch Set #5, Line 319: }

    /* TODO for UTRAN */ here I guess?

• File src/sgsn/sgsn_vty.c:

  • Patch Set #5, Line 1338: rate_ctr_inc(rate_ctr_group_get_ctr(mm->ctrg, GMM_CTR_PAGING_PS));

    I don't really like the fact that now we have this counter incremented in several places. I'd put this into the function doing the paging.

To view, visit change 37866. To unsubscribe, or for help writing mail filters, visit settings.