Attention is currently required from: arehbein. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/33381 ) Change subject: src/grd: Add option for cherry-picking ...................................................................... Patch Set 1: Code-Review+1 (4 comments) Patchset: PS1: nice! some nitpicks, LGTM otherwise File src/grd: https://gerrit.osmocom.org/c/osmo-dev/+/33381/comment/eb646661_18b00e04 PS1, Line 73: cmd = ["git", "cherry-pick", "FETCH_HEAD"]; for consistency: let's also print the command, like in git_checkout_fetch_head() https://gerrit.osmocom.org/c/osmo-dev/+/33381/comment/857ed8ce_2e66f027 PS1, Line 95: , disabled by default I'd remove the ", disabled by default" part, it is redundant as this is an optional parameter and the default action is already described as "instead of fetching into a branch". https://gerrit.osmocom.org/c/osmo-dev/+/33381/comment/3a68c152_0659dd3d PS1, Line 112: git_cherry_pick_fetch_head() I'd switch the logic, so the non-inverted case comes first: ``` if args.cherry_pick: ... else: ... ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/33381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I85b1a2c4915e3da374e4b1201f2e977708fc7c4c Gerrit-Change-Number: 33381 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: arehbein <arehbein@sysmocom.de> Gerrit-Comment-Date: Tue, 20 Jun 2023 14:37:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment