Attention is currently required from: arehbein.

Patch set 1:Code-Review +1

View Change

4 comments:

• Patchset:

  • Patch Set #1:

    nice! some nitpicks, LGTM otherwise

• File src/grd:

  • Patch Set #1, Line 73: cmd = ["git", "cherry-pick", "FETCH_HEAD"];

    for consistency: let's also print the command, like in git_checkout_fetch_head()

  • Patch Set #1, Line 95: , disabled by default

    I'd remove the ", disabled by default" part, it is redundant as this is an optional parameter and the default action is already described as "instead of fetching into a branch".

  • Patch Set #1, Line 112: git_cherry_pick_fetch_head()

    I'd switch the logic, so the non-inverted case comes first:

    ```
    if args.cherry_pick:
        ...
    else:
        ...
    ```

To view, visit change 33381. To unsubscribe, or for help writing mail filters, visit settings.