Change in osmo-mgw[master]: mgcp_network: log RTP/RTCP reception failures

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27608 ) Change subject: mgcp_network: log RTP/RTCP reception failures ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/27608/comment/7dc5dd1f_1ec440f7 PS1, Line 1515: if (rc < 0) { I would avoid this. an error can be returned here due to potentially a big amount of different reasons. It makes much more sense logging specific stuff at the moment something fails rather than here. Specially since basically failing here doesn't really change the behavior of MGW. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27608 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic0e60fe2fb9d96b8ae18bb862b5715359a10e849 Gerrit-Change-Number: 27608 Gerrit-PatchSet: 1 Gerrit-Owner: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: dexter &lt;pmaier(a)sysmocom.de&gt; Gerrit-Comment-Date: Wed, 30 Mar 2022 14:25:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment