Attention is currently required from: dexter.

Patch set 1:Code-Review -1

View Change

1 comment:

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #1, Line 1515: if (rc < 0) {

    I would avoid this. an error can be returned here due to potentially a big amount of different reasons. It makes much more sense logging specific stuff at the moment something fails rather than here. Specially since basically failing here doesn't really change the behavior of MGW.

To view, visit change 27608. To unsubscribe, or for help writing mail filters, visit settings.