Attention is currently required from: daniel, lynxis lazus.
pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007?usp=email )
Change subject: TCAP: Refactoring unroutable messages into own function ......................................................................
Patch Set 2:
(3 comments)
File src/tcap_as_loadshare.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007/comment/a870b372_d955f9... : PS2, Line 466: static int asp_loadshare_tcap_unroutable(struct osmo_ss7_asp **rasp, asp_loadshare_tcap_unroutable_fallback() may be more descriptive. Otherwise it seems ike you are testing wether a msg is unroutable, which is not really the case here.
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007/comment/c414a3d5_2c81e7... : PS2, Line 608: rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK); AFAIU this patch could be reduce to only adding the following line here:
if (!asp) goto out_free_sua;
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007/comment/0dca39ef_0abbdf... : PS2, Line 636: rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK); AFAIU this patch could be reduce to only adding the following line here:
if (!asp) goto out_free_sua;