Attention is currently required from: daniel, lynxis lazus.

View Change

3 comments:

• File src/tcap_as_loadshare.c:

  • Patch Set #2, Line 466: static int asp_loadshare_tcap_unroutable(struct osmo_ss7_asp **rasp,

    asp_loadshare_tcap_unroutable_fallback() may be more descriptive.
    Otherwise it seems ike you are testing wether a msg is unroutable, which is not really the case here.

  • Patch Set #2, Line 608: rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK);

    AFAIU this patch could be reduce to only adding the following line here:

        if (!asp)
            goto out_free_sua;

  • Patch Set #2, Line 636: rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK);

    AFAIU this patch could be reduce to only adding the following line here:

        if (!asp)
            goto out_free_sua;

To view, visit change 43007. To unsubscribe, or for help writing mail filters, visit settings.