Attention is currently required from: laforge, pespin, dexter. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 ) Change subject: mgw_fsm: add MGW support to osmo-hnbgw ...................................................................... Patch Set 18: (2 comments) Patchset: PS17:
my comments from previous version still apply. At the moment everything should be fixed. I might have overlooked something though.
Patchset: PS18: This is still work in progress (I haven't set it to work in progress though because I have the feeling that would prevents people from reviewing this.) One thing that still needs to be addressed is a better error handling. So, basically the question what happens when a RANAP RAB AssignmentRequest is processed but the FSM died because of an error. Or what happens when a RANAP RAB AssignmentResponse comes back from the HnodeB and the FSM is not there, or it is there, but the response is an unsuccessful outcome? This also needs to be covered by the TTCN3 tests as well, so that we can test. Otherwise the implementation behaves fine when tested manually. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib9b62e0145184b91c56ce5d8870760bfa49cc5a4 Gerrit-Change-Number: 26795 Gerrit-PatchSet: 18 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Wed, 02 Feb 2022 13:42:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment