Attention is currently required from: laforge, fixeria. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30743 ) Change subject: {trxcon,virt_phy}: shared GPRS L1 (MAC) implementation ...................................................................... Patch Set 11: (2 comments) File src/shared/l1gprs.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30743/comment/7298da8c_73f50d87 PS10, Line 111: if (tbf->uplink) {
Again sounds like you could perfectly have 2 functions. […] No, I don't want to have two 90% identical structs. The only difference between them is presence of the `dl_tfi` field.
https://gerrit.osmocom.org/c/osmocom-bb/+/30743/comment/e576592b_16b3c562 PS10, Line 294: l1gprs_register_tbf(gprs, tbf);
I think it may be good to always first unregister, and if != 0x00, also register. […] I was thinking about this. But is it possible on practice that you need to modify a TBF? I mean, you always get a new TBF with different parameters from the network, there is no protocol level message to modify an existing TBF, is there?
-- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30743 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9567d64f9d00262e36147e8d7e541e5e246bda5f Gerrit-Change-Number: 30743 Gerrit-PatchSet: 11 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 16 Mar 2023 14:35:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment