Attention is currently required from: laforge, fixeria.

View Change

2 comments:

• File src/shared/l1gprs.c:

  • Patch Set #10, Line 111: if (tbf->uplink) {

    Again sounds like you could perfectly have 2 functions. […]

    No, I don't want to have two 90% identical structs.
    The only difference between them is presence of the `dl_tfi` field.

  • Patch Set #10, Line 294: l1gprs_register_tbf(gprs, tbf);

    I think it may be good to always first unregister, and if != 0x00, also register. […]

    I was thinking about this. But is it possible on practice that you need to modify a TBF? I mean, you always get a new TBF with different parameters from the network, there is no protocol level message to modify an existing TBF, is there?

To view, visit change 30743. To unsubscribe, or for help writing mail filters, visit settings.