Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620?usp=email )
Change subject: IPAd: Add test case for multple eIM packages ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1: To me this looks good, just two suggestions regarding the rounds parameter.
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620/comment/4903035c_33dde... : PS1, Line 1170: var integer i, rounds := 5; maybe have the rounds parameter as a module parameter? (mp_tc_multi_package_rounds)?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620/comment/410bb9bc_8f0e5... : PS1, Line 1209: f_init(id, 300.0); maybe write t_guard := 300.0, than its more obvious what the number means. You could also interoperate the rounds parameter. t_guard := rounds * 6.0 ?