Attention is currently required from: jolly.

Patch set 1:Code-Review +1

View Change

3 comments:

• Patchset:

  • Patch Set #1:

    To me this looks good, just two suggestions regarding the rounds parameter.

• File ipad/IPAd_Tests.ttcn:

  • Patch Set #1, Line 1170: var integer i, rounds := 5;

    maybe have the rounds parameter as a module parameter? (mp_tc_multi_package_rounds)?

  • Patch Set #1, Line 1209: f_init(id, 300.0);

    maybe write t_guard := 300.0, than its more obvious what the number means. You could also interoperate the rounds parameter. t_guard := rounds * 6.0 ?

To view, visit change 43620. To unsubscribe, or for help writing mail filters, visit settings.