Attention is currently required from: laforge, neels, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email ) Change subject: Validate session remote CP F-SEID and use it to transmit session requests ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/osmo-upf/up_endpoint.c: https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/fc237059_526bb4b4?usp=... : PS1, Line 217: nack_response
I think it's fine having it this, way it's only 3 lines of code ...
+2 for the `resp` and `cause` variables, +1 for the label name. Not super critical, but a separate function would still be cleaner IMO. File src/osmo-upf/up_session.c: https://gerrit.osmocom.org/c/osmo-upf/+/41482/comment/c3b973b7_85b88960?usp=... : PS1, Line 115: return NULL;
I also thought about it, and tbh I only added this return to avoid warnings on older compilers/stati […] Fine with me.
-- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/41482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ifccd4d2b8d500c9928778400bb096baaa12c9a31 Gerrit-Change-Number: 41482 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 01 Dec 2025 16:14:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>