Attention is currently required from: laforge, neels, osmith, pespin.

Patch set 2:Code-Review +1

View Change

2 comments:

• File src/osmo-upf/up_endpoint.c:

  • Patch Set #1, Line 217: nack_response

    I think it's fine having it this, way it's only 3 lines of code ...

    +2 for the `resp` and `cause` variables, +1 for the label name.

    Not super critical, but a separate function would still be cleaner IMO.

• File src/osmo-upf/up_session.c:

  • Patch Set #1, Line 115: return NULL;

    I also thought about it, and tbh I only added this return to avoid warnings on older compilers/stati […]

    Fine with me.

To view, visit change 41482. To unsubscribe, or for help writing mail filters, visit settings.