Attention is currently required from: laforge, fixeria, pespin, dexter.
jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32930 )
Change subject: ASCI: Add 3GPP TS 44.068 and 44.069 protocol definitions ......................................................................
Patch Set 3:
(5 comments)
File include/osmocom/gsm/protocol/gsm_44_068.h:
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/5b49d759_9aafde41 PS1, Line 9: (C) 2023 by Andreas Eversberg jolly@eversberg.eu
copyright is with sysmocom for code written by employees during work time. […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/38db82ee_812e4a1d PS1, Line 19: enum gcc_iei {
missing osmo_ prefix in all definitions, in order to keep everything in the same namespace. […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/84ba6ad6_6ad5e27b PS1, Line 19: enum gcc_iei {
in general we try to avoid clobbering the global namespace with symbols or type names without an osm […]
Done
File src/gsm/gsm44068.c:
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/db5d71cd_e4d5667d PS1, Line 22: const struct value_string gcc_msg_type_names[] = {
osmo_* and OSMO_* prefix missing everywhere.
Done
File src/gsm/libosmogsm.map:
https://gerrit.osmocom.org/c/libosmocore/+/32930/comment/2d298547_6f41fe70 PS1, Line 474: gcc_msg_type_names;
Ideally, all new symbols should be prefixed with `osmo_`. […]
Done