Attention is currently required from: laforge, fixeria, pespin, dexter.

View Change

5 comments:

• File include/osmocom/gsm/protocol/gsm_44_068.h:

  • Patch Set #1, Line 9: (C) 2023 by Andreas Eversberg <jolly@eversberg.eu>

    copyright is with sysmocom for code written by employees during work time. […]

    Done

  • Patch Set #1, Line 19: enum gcc_iei {

    missing osmo_ prefix in all definitions, in order to keep everything in the same namespace. […]

    Done

  • Patch Set #1, Line 19: enum gcc_iei {

    in general we try to avoid clobbering the global namespace with symbols or type names without an osm […]

    Done

• File src/gsm/gsm44068.c:

  • Patch Set #1, Line 22: const struct value_string gcc_msg_type_names[] = {

    osmo_* and OSMO_* prefix missing everywhere.

    Done

• File src/gsm/libosmogsm.map:

  • Patch Set #1, Line 474: gcc_msg_type_names;

    Ideally, all new symbols should be prefixed with `osmo_`. […]

    Done

To view, visit change 32930. To unsubscribe, or for help writing mail filters, visit settings.