[S] Change in libosmo-sigtran[master]: sccp2sua: fix buffer overrun in osmo_isup_party_parse()

Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163?usp=email )

Change subject: sccp2sua: fix buffer overrun in osmo_isup_party_parse() ......................................................................

Patch Set 2:

(1 comment)

File src/sccp2sua.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/43163/comment/0982b8f9_420cc6... : PS1, Line 74: if (in_num_bytes * 2 >= out_digits_size)

Note that the check is using `>=`, i.e. […]

Ah, I guess I know what you mean. The output buffer is `digits[32]`, so we can accept up to 31 BCD-digits + `'\0'`. If the input is `in_num_bytes=32` and `odd=true` (i.e. the input contains 31 BCD-digits), we'll reject it for no good reason. I'll rework the patch.