Attention is currently required from: pespin.

View Change

1 comment:

• File src/sccp2sua.c:

  • Patch Set #1, Line 74: if (in_num_bytes * 2 >= out_digits_size)

    Note that the check is using `>=`, i.e. […]

    Ah, I guess I know what you mean. The output buffer is `digits[32]`, so we can accept up to 31 BCD-digits + `'\0'`. If the input is `in_num_bytes=32` and `odd=true` (i.e. the input contains 31 BCD-digits), we'll reject it for no good reason. I'll rework the patch.

To view, visit change 43163. To unsubscribe, or for help writing mail filters, visit settings.