Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35550?usp=email ) Change subject: test: adjust for libosmocore loglevel cache ...................................................................... Patch Set 1: (1 comment) File tests/handover/handover_test.c: https://gerrit.osmocom.org/c/osmo-bts/+/35550/comment/da8fe317_dfcda4ff PS1, Line 73: osmo_stderr_target->categories[DHO].loglevel = LOGL_DEBUG;
Because this unrelated
I disagree. This is related. By using the right API we kill two birds with one stone: fix accessing logging internals and ensure that the cache is properly updated. If these tests used `log_set_category_filter()`, we would not end up having those regressions...
test code is always weird/old and rarely does things normal code "should" do things.
I am not getting the point here. Yes, tests may be receiving less care from developers and do something improperly, but does it mean that we should not fix tests? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35550?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie9c546210bc554843b1029afa20965bde1d7f228 Gerrit-Change-Number: 35550 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Comment-Date: Thu, 11 Jan 2024 18:17:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment