Attention is currently required from: Hoernchen.

View Change

1 comment:

• File tests/handover/handover_test.c:

  • Patch Set #1, Line 73: osmo_stderr_target->categories[DHO].loglevel = LOGL_DEBUG;

    Because this unrelated

    I disagree. This is related. By using the right API we kill two birds with one stone: fix accessing logging internals and ensure that the cache is properly updated. If these tests used `log_set_category_filter()`, we would not end up having those regressions...

    test code is always weird/old and rarely does things normal code "should" do things.

    I am not getting the point here. Yes, tests may be receiving less care from developers and do something improperly, but does it mean that we should not fix tests?

To view, visit change 35550. To unsubscribe, or for help writing mail filters, visit settings.