Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email ) Change subject: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN ...................................................................... Patch Set 3: (4 comments) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/e39eedee_745c13... : PS2, Line 985: goto out;
yes, but actually we need to fix this in general. What do you mean? why not sending it here?
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/97984f87_427a1c... : PS2, Line 990: asp->tcap.enabled = true;
It depends how you would like to use this feature. […] I'd leave it as before and simply add a new message which can be sent before enabling it, this follows better backward compatibility imho.
File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/e655ef4d_88262e... : PS3, Line 264: assoc->asp->tcap.enabled && assoc->asp->tcap.accept_new_trans) Please put the added condition into a new line. File src/tcap_as_loadshare_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/92983017_cfaa36... : PS3, Line 161: if (!assoc->asp->tcap.enabled || !osmo_ss7_asp_active(assoc->asp)) it probably makes sense to also print the inactive ones and add a column which prints "ACTIVE" | "INACT" (have a look at already existing vty show commands to use same terminology). -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id4e7bb022a0c8b52369f6ded2729cf6cf8679556 Gerrit-Change-Number: 43999 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis <lynxis@fe80.eu> Gerrit-Comment-Date: Thu, 12 Nov 2026 15:16:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: lynxis <lynxis@fe80.eu>