Attention is currently required from: lynxis.
4 comments:
File src/tcap_as_loadshare.c:
Patch Set #2, Line 985: goto out;
yes, but actually we need to fix this in general.
What do you mean? why not sending it here?
Patch Set #2, Line 990: asp->tcap.enabled = true;
It depends how you would like to use this feature. […]
I'd leave it as before and simply add a new message which can be sent before enabling it, this follows better backward compatibility imho.
File src/tcap_as_loadshare.c:
Patch Set #3, Line 264: assoc->asp->tcap.enabled && assoc->asp->tcap.accept_new_trans)
Please put the added condition into a new line.
File src/tcap_as_loadshare_vty.c:
Patch Set #3, Line 161: if (!assoc->asp->tcap.enabled || !osmo_ss7_asp_active(assoc->asp))
it probably makes sense to also print the inactive ones and add a column which prints "ACTIVE" | "INACT" (have a look at already existing vty show commands to use same terminology).
To view, visit change 43999. To unsubscribe, or for help writing mail filters, visit settings.