Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43044?usp=email )
Change subject: V1.2: Add function ES10b.DisableEmergencyProfile ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
File include/onomondo/ipa/ipad.h:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43044/comment/152d9447_f5c1ce33?... : PS3, Line 100: int ipa_disable_emergency_profile(struct ipa_context *ctx); maybe shorten "profile" to "prfle" and "emergency" to "emerg"?
File src/ipa/libipa/es10b_dis_emerg_prfle.h:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43044/comment/ee9fba39_2eeedfbf?... : PS3, Line 14: struct DisableEmergencyProfileResponse *res; Also here, maybe just return the integer result?
File src/ipa/main.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43044/comment/3c407d0d_264c228f?... : PS3, Line 56: printf(" --disable-emergency-profile. Trigger return from emergency profile to previous profile\n");
see my comment on an earlier patch of this series about options that are […]
Acknowledged